linux-kernel - Re: [PATCH 32/33] Input: sis_i2c - Drop unnecessary call to i2c_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170118222715.GA11881@dtor-ws>
Date:   Wed, 18 Jan 2017 14:27:15 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mika Penttilä <mika.penttila@...tfour.com>,
        Tammy Tseng <tammy_tseng@....com>, Yuger Yu <yuger_yu@....com>
Subject: Re: [PATCH 32/33] Input: sis_i2c - Drop unnecessary call to
 i2c_set_clientdata and other changes

On Wed, Jan 18, 2017 at 12:36:49PM -0800, Guenter Roeck wrote:
> There is no call to i2c_get_clientdata() or dev_get_drvdata().
> Drop the unnecessary call to i2c_set_clientdata().
> 
> This conversion was done automatically with coccinelle using the
> following semantic patches. The semantic patches and the scripts
> used to generate this commit log are available at
> https://github.com/groeck/coccinelle-patches
> 
> - Drop i2c_set_clientdata()
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Applied, thank you.

> ---
>  drivers/input/touchscreen/sis_i2c.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/sis_i2c.c b/drivers/input/touchscreen/sis_i2c.c
> index 8d93f8c9a403..67c2563031d6 100644
> --- a/drivers/input/touchscreen/sis_i2c.c
> +++ b/drivers/input/touchscreen/sis_i2c.c
> @@ -316,7 +316,6 @@ static int sis_ts_probe(struct i2c_client *client,
>  		return -ENOMEM;
>  
>  	ts->client = client;
> -	i2c_set_clientdata(client, ts);
>  
>  	ts->attn_gpio = devm_gpiod_get_optional(&client->dev,
>  						"attn", GPIOD_IN);
> -- 
> 2.7.4
> 

-- 
Dmitry