linux-kernel - Re: [PATCH v3 1/5] staging: fbtft: convert fbtft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170119094914.GA5162@kroah.com>
Date:   Thu, 19 Jan 2017 10:49:14 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Noralf Trønnes <noralf@...nnes.org>,
        devel@...verdev.osuosl.org,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/5] staging: fbtft: convert fbtft_reset() to be
 non-atomic

On Tue, Jan 03, 2017 at 08:29:45PM +0200, Andy Shevchenko wrote:
> First of all, fbtft in current state doesn't allow to override GPIOs to be
> optional, like "reset" one. It might be a bug somewhere, but rather out of
> scope of this fix.
> 
> Second, not all GPIOs available on the board would be SoC based, some of them
> might sit on I2C GPIO expanders, for example, on Intel Edison/Arduino, and thus
> any communication with them might sleep.
> 
> Besides that using udelay() and mdelay() is kinda resource wasteful.
> 
> Summarize all of the above, convert fbtft_reset() function to non-atomic
> variant by using gpio_set_value_cansleep(), usleep_range(), and msleep().
> 
> Reviewed-by: Noralf Trønnes <noralf@...nnes.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Andy, this series came through with the charmap all corrupted and git
didn't like them at all.  Can you fix up and resend?

thanks,

greg k-h