linux-kernel - Re: [PATCH 0/2] Introduce AMD Secure Processor device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0442f536-221d-fcef-3009-4bc07403ccd8@amd.com>
Date:   Thu, 19 Jan 2017 14:03:12 -0600
From:   Brijesh Singh <brijesh.singh@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <brijesh.singh@....com>, <thomas.lendacky@....com>,
        <herbert@...dor.apana.org.au>, <arnd@...db.de>,
        <lambert.quentin@...il.com>, <gary.hook@....com>,
        <linux-kernel@...r.kernel.org>, <Julia.Lawall@...6.fr>,
        <weiyongjun1@...wei.com>, <linux-crypto@...r.kernel.org>,
        <umgwanakikbuti@...il.com>
Subject: Re: [PATCH 0/2] Introduce AMD Secure Processor device

Hi Greg,

On 01/19/2017 12:21 PM, Greg KH wrote:
> On Thu, Jan 19, 2017 at 01:07:50PM -0500, Brijesh Singh wrote:
>> The CCP device (drivers/crypto/ccp/ccp.ko) is part of AMD Secure Processor,
>> which is not dedicated solely to crypto. The AMD Secure Processor includes
>> CCP and PSP (Platform Secure Processor) devices.
>>
>> This patch series moves the CCP device driver to the misc directory and
>> creates a framework that allows functional component of the AMD Secure
>> Processor to be initialized and handled appropriately.
>
> Why the misc directory?  I don't see the justification here...
>

Since this driver is not solely for crypto purposes and do not fit in 
any of the standard categories hence I thought of moving it into misc 
directory. I am open to other suggestions unless Herbert is ok with 
leaving it into crypto and allowing the addition of the Secure Processor 
support.

The patch series allows the CCP driver to support other Secure Processor 
functions, e.g Secure Encrypted Virtualization (SEV) key management. In 
past, I tried to add SEV support into existing CCP driver [1] but we 
quickly learned that CCP driver should be moved outside the crypto 
directory otherwise will end up adding non crypto code into 
drivers/crypto directory. Once this cleanup is accepted then I can work 
to add SEV support inside the CCP driver.

[1] http://marc.info/?l=linux-kernel&m=147204118426151&w=2

-Brijesh