linux-kernel - Re: [PATCH 1/2] crypto: move CCP device driver to misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e6f9e9d-3a84-0aa4-d42a-c152fd75f884@amd.com>
Date:   Thu, 19 Jan 2017 13:10:54 -0600
From:   Brijesh Singh <brijesh.singh@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <brijesh.singh@....com>, <thomas.lendacky@....com>,
        <herbert@...dor.apana.org.au>, <arnd@...db.de>,
        <lambert.quentin@...il.com>, <gary.hook@....com>,
        <linux-kernel@...r.kernel.org>, <Julia.Lawall@...6.fr>,
        <weiyongjun1@...wei.com>, <linux-crypto@...r.kernel.org>,
        <umgwanakikbuti@...il.com>
Subject: Re: [PATCH 1/2] crypto: move CCP device driver to misc

Hi Greg,

On 01/19/2017 12:18 PM, Greg KH wrote:
> On Thu, Jan 19, 2017 at 01:08:01PM -0500, Brijesh Singh wrote:
>> The CCP device is part of the AMD Secure Processor, which is not dedicated
>> solely to crypto. Move the CCP device driver to the misc directory in
>> prepration for expanding the usage of the AMD Secure Processor. Leaving the
>> CCP cryptographic layer (the ccp-crypto* files) in their current directory.
>>
>> Signed-off-by: Brijesh Singh <brijesh.singh@....com>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@....com>
>> ---
>>  drivers/crypto/Kconfig              |   11
>>  drivers/crypto/Makefile             |    2
>>  drivers/crypto/ccp/Kconfig          |   21
>>  drivers/crypto/ccp/Makefile         |    9
>>  drivers/crypto/ccp/ccp-dev-v3.c     |  574 -----------
>>  drivers/crypto/ccp/ccp-dev-v5.c     | 1021 -------------------
>>  drivers/crypto/ccp/ccp-dev.c        |  588 -----------
>>  drivers/crypto/ccp/ccp-dev.h        |  647 ------------
>>  drivers/crypto/ccp/ccp-dmaengine.c  |  728 --------------
>>  drivers/crypto/ccp/ccp-ops.c        | 1876 -----------------------------------
>>  drivers/crypto/ccp/ccp-pci.c        |  354 -------
>>  drivers/crypto/ccp/ccp-platform.c   |  293 -----
>>  drivers/misc/Kconfig                |    1
>>  drivers/misc/Makefile               |    1
>>  drivers/misc/amd-sp/Kconfig         |   14
>>  drivers/misc/amd-sp/Makefile        |    8
>>  drivers/misc/amd-sp/ccp-dev-v3.c    |  574 +++++++++++
>>  drivers/misc/amd-sp/ccp-dev-v5.c    | 1021 +++++++++++++++++++
>>  drivers/misc/amd-sp/ccp-dev.c       |  588 +++++++++++
>>  drivers/misc/amd-sp/ccp-dev.h       |  647 ++++++++++++
>>  drivers/misc/amd-sp/ccp-dmaengine.c |  728 ++++++++++++++
>>  drivers/misc/amd-sp/ccp-ops.c       | 1876 +++++++++++++++++++++++++++++++++++
>>  drivers/misc/amd-sp/ccp-pci.c       |  354 +++++++
>>  drivers/misc/amd-sp/ccp-platform.c  |  293 +++++
>>  include/linux/ccp.h                 |    3
>>  25 files changed, 6111 insertions(+), 6121 deletions(-)
>>  delete mode 100644 drivers/crypto/ccp/ccp-dev-v3.c
>>  delete mode 100644 drivers/crypto/ccp/ccp-dev-v5.c
>>  delete mode 100644 drivers/crypto/ccp/ccp-dev.c
>>  delete mode 100644 drivers/crypto/ccp/ccp-dev.h
>>  delete mode 100644 drivers/crypto/ccp/ccp-dmaengine.c
>>  delete mode 100644 drivers/crypto/ccp/ccp-ops.c
>>  delete mode 100644 drivers/crypto/ccp/ccp-pci.c
>>  delete mode 100644 drivers/crypto/ccp/ccp-platform.c
>>  create mode 100644 drivers/misc/amd-sp/Kconfig
>>  create mode 100644 drivers/misc/amd-sp/Makefile
>>  create mode 100644 drivers/misc/amd-sp/ccp-dev-v3.c
>>  create mode 100644 drivers/misc/amd-sp/ccp-dev-v5.c
>>  create mode 100644 drivers/misc/amd-sp/ccp-dev.c
>>  create mode 100644 drivers/misc/amd-sp/ccp-dev.h
>>  create mode 100644 drivers/misc/amd-sp/ccp-dmaengine.c
>>  create mode 100644 drivers/misc/amd-sp/ccp-ops.c
>>  create mode 100644 drivers/misc/amd-sp/ccp-pci.c
>>  create mode 100644 drivers/misc/amd-sp/ccp-platform.c
>
> Please create your patch with -M, to show this is a rename, or a change
> with a rename.  Otherwise this is an impossible patch to review, would
> you want to try to do it?
>

Thanks for the tip, will re-generate the patches with -M.