linux-kernel - Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170120232049.GB20800@codeaurora.org>
Date:   Fri, 20 Jan 2017 15:20:49 -0800
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Stanimir Varbanov <stanimir.varbanov@...aro.org>
Cc:     Rajendra Nayak <rnayak@...eaurora.org>, mturquette@...libre.com,
        linux-clk@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, sricharan@...eaurora.org
Subject: Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control
 enable/disable

On 01/10, Stanimir Varbanov wrote:
> 
> > +		udelay(1);
> > +
> > +		reg = sc->gds_hw_ctrl ? sc->gds_hw_ctrl : sc->gdscr;
> > +		ret = gdsc_poll_status(sc, reg, 0);
> 
> This should be gdsc_poll_status(sc, reg, true) because after disabling
> hw_control we expect that the GDSC is in power_on state.
> 
> > +		if (ret)
> > +			return ret;
> >  	}
> >  
> >  	if (sc->pwrsts & PWRSTS_OFF)
> > 

I expect this patch is going for v2?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project