linux-kernel - Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5885807E.7040500@codeaurora.org>
Date:   Mon, 23 Jan 2017 09:33:10 +0530
From:   Rajendra Nayak <rnayak@...eaurora.org>
To:     Stephen Boyd <sboyd@...eaurora.org>,
        Stanimir Varbanov <stanimir.varbanov@...aro.org>
CC:     mturquette@...libre.com, linux-clk@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        sricharan@...eaurora.org
Subject: Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable



On 01/21/2017 04:50 AM, Stephen Boyd wrote:
> On 01/10, Stanimir Varbanov wrote:
>>
>>> +		udelay(1);
>>> +
>>> +		reg = sc->gds_hw_ctrl ? sc->gds_hw_ctrl : sc->gdscr;
>>> +		ret = gdsc_poll_status(sc, reg, 0);
>>
>> This should be gdsc_poll_status(sc, reg, true) because after disabling
>> hw_control we expect that the GDSC is in power_on state.
>>
>>> +		if (ret)
>>> +			return ret;
>>>  	}
>>>  
>>>  	if (sc->pwrsts & PWRSTS_OFF)
>>>
> 
> I expect this patch is going for v2?

Yes, sorry, coming up shortly.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation