linux-kernel - Re: [PATCH] iio: health: afe4403: retrieve a valid iio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21e9df05-1918-cb17-d83a-e2c36e70851b@kernel.org>
Date:   Sat, 21 Jan 2017 13:12:00 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     "Andrew F. Davis" <afd@...com>,
        Alison Schofield <amsfield22@...il.com>
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in
 suspend/resume

On 16/01/17 16:38, Andrew F. Davis wrote:
> On 01/14/2017 09:51 PM, Alison Schofield wrote:
>> The suspend/resume functions were using dev_to_iio_dev() to get
>> the iio_dev. That only works on IIO dev's.  Replace it with spi
>> functions to get the correct iio_dev.
>>
>> Signed-off-by: Alison Schofield <amsfield22@...il.com>
> 
> Was this found with an automated tool? If not, it might be nice to have
> a Coccinelle style check for this. Anyway for this and the afe4404
> version patch:
> 
> Acked-by: Andrew F. Davis <afd@...com>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan
> 
>> ---
>>  drivers/iio/health/afe4403.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c
>> index 9a08146..6bb23a4 100644
>> --- a/drivers/iio/health/afe4403.c
>> +++ b/drivers/iio/health/afe4403.c
>> @@ -422,7 +422,7 @@ MODULE_DEVICE_TABLE(of, afe4403_of_match);
>>  
>>  static int __maybe_unused afe4403_suspend(struct device *dev)
>>  {
>> -	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>> +	struct iio_dev *indio_dev = spi_get_drvdata(to_spi_device(dev));
>>  	struct afe4403_data *afe = iio_priv(indio_dev);
>>  	int ret;
>>  
>> @@ -443,7 +443,7 @@ static int __maybe_unused afe4403_suspend(struct device *dev)
>>  
>>  static int __maybe_unused afe4403_resume(struct device *dev)
>>  {
>> -	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>> +	struct iio_dev *indio_dev = spi_get_drvdata(to_spi_device(dev));
>>  	struct afe4403_data *afe = iio_priv(indio_dev);
>>  	int ret;
>>  
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>