linux-kernel - Re: [PATCH] iio: health: afe4404: retrieve a valid iio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <921be868-529b-bac2-dbca-f1a8ad943cf7@kernel.org>
Date:   Sat, 21 Jan 2017 13:13:43 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alison Schofield <amsfield22@...il.com>
Cc:     afd@...com, knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: health: afe4404: retrieve a valid iio_dev in
 suspend/resume

On 15/01/17 03:52, Alison Schofield wrote:
> The suspend/resume functions were using dev_to_iio_dev() to get
> the iio_dev. That only works on IIO dev's.  Replace it with i2c
> functions to get the correct iio_dev.
> 
> Signed-off-by: Alison Schofield <amsfield22@...il.com>
Applied with Andrew's Ack.
> ---
>  drivers/iio/health/afe4404.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/health/afe4404.c b/drivers/iio/health/afe4404.c
> index 4526640..964f523 100644
> --- a/drivers/iio/health/afe4404.c
> +++ b/drivers/iio/health/afe4404.c
> @@ -428,7 +428,7 @@ MODULE_DEVICE_TABLE(of, afe4404_of_match);
>  
>  static int __maybe_unused afe4404_suspend(struct device *dev)
>  {
> -	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> +	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
>  	struct afe4404_data *afe = iio_priv(indio_dev);
>  	int ret;
>  
> @@ -449,7 +449,7 @@ static int __maybe_unused afe4404_suspend(struct device *dev)
>  
>  static int __maybe_unused afe4404_resume(struct device *dev)
>  {
> -	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> +	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
>  	struct afe4404_data *afe = iio_priv(indio_dev);
>  	int ret;
>  
>