lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 23 Jan 2017 11:39:59 +0000
From:   Lee Jones <>
To:     Javier Martinez Canillas <>
Cc:     Chanwoo Choi <>,,
        Laxman Dewangan <>,
        Krzysztof Kozlowski <>,
        Bartlomiej Zolnierkiewicz <>
Subject: Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

On Mon, 16 Jan 2017, Javier Martinez Canillas wrote:

> Hello Chanwoo,
> Thanks for the review.
> On 01/16/2017 03:46 AM, Chanwoo Choi wrote:
> > Hi,
> > 
> > I think that this patch better to squash with patch3.
> > After applying the patch3, this driver doesn't use
> > the max77686_i2c_id table.
> > 
> I usually prefer to separate each change in a different patch,
> AFAICT moving to use the .probe_new callback and removing the
> I2C id table are two different changes.
> I can squash if that's the correct approach though, I will let
> Lee decide.

This should really be a single patch, as the previous one leaves this
code redundant, but ... meh!

Lee Jones
Linaro STMicroelectronics Landing Team Lead │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Powered by blists - more mailing lists