linux-kernel - Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2017 11:40:10 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org,
        Laxman Dewangan <ldewangan@...dia.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

On Fri, 13 Jan 2017, Javier Martinez Canillas wrote:

> The driver is only used in DT platforms so there's no need to
> have an i2c_device_id table.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> Acked-by: Laxman Dewangan <ldewangan@...dia.com>
> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
> Tested-by: Krzysztof Kozlowski <krzk@...nel.org>
> 
> ---
> 
> Changes in v2:
> - Add Laxman's Acked-by tag to patch 4/4.
> - Add Krzysztof's Reviewed-by and Tested-by tags to patch 4/4.
> 
>  drivers/mfd/max77686.c | 8 --------
>  1 file changed, 8 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 896c1bf85acc..b0e8e13c0049 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -241,13 +241,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c)
>  	return 0;
>  }
>  
> -static const struct i2c_device_id max77686_i2c_id[] = {
> -	{ "max77686", TYPE_MAX77686 },
> -	{ "max77802", TYPE_MAX77802 },
> -	{ }
> -};
> -MODULE_DEVICE_TABLE(i2c, max77686_i2c_id);
> -
>  #ifdef CONFIG_PM_SLEEP
>  static int max77686_suspend(struct device *dev)
>  {
> @@ -294,7 +287,6 @@ static struct i2c_driver max77686_i2c_driver = {
>  		   .of_match_table = of_match_ptr(max77686_pmic_dt_match),
>  	},
>  	.probe_new = max77686_i2c_probe,
> -	.id_table = max77686_i2c_id,
>  };
>  
>  module_i2c_driver(max77686_i2c_driver);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog