linux-kernel - Re: linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <534e45bf-8a2c-85e4-e18e-0c95a9f97e40@xilinx.com>
Date:   Mon, 23 Jan 2017 12:54:11 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     David Binderman <dcb314@...mail.com>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "soren.brinkmann@...inx.com" <soren.brinkmann@...inx.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer_icap.c: 2 *
 pointless local variables ?

On 23.1.2017 12:39, David Binderman wrote:
> 
> Hello there,
> 
> [linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer_icap.c:301]: (style) Variable 'num_writes' is modified but its new value is never used.
> [linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer_icap.c:356]: (style) Variable 'read_count' is modified but its new value is never used.
> 
> Suggest either use these local variables in some way or delete them.
> 

I have sent patch which removes them.

Thanks,
Michal