linux-kernel - Re: [PATCH] mfd: tps65912: Export OF device ID table as module aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170123115845.GI16020@dell>
Date:   Mon, 23 Jan 2017 11:58:45 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: tps65912: Export OF device ID table as module
 aliases

On Mon, 16 Jan 2017, Javier Martinez Canillas wrote:

> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
> 
> Before this patch:
> 
> $ modinfo drivers/mfd/tps65912-i2c.ko | grep alias
> alias:          i2c:tps65912
> 
> After this patch:
> 
> $ modinfo drivers/mfd/tps65912-i2c.ko | grep alias
> alias:          of:N*T*Cti,tps65912C*
> alias:          of:N*T*Cti,tps65912
> alias:          i2c:tps65912
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> ---
> 
>  drivers/mfd/tps65912-i2c.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/tps65912-i2c.c b/drivers/mfd/tps65912-i2c.c
> index 45871403f995..785d19f6f7c9 100644
> --- a/drivers/mfd/tps65912-i2c.c
> +++ b/drivers/mfd/tps65912-i2c.c
> @@ -27,6 +27,7 @@ static const struct of_device_id tps65912_i2c_of_match_table[] = {
>  	{ .compatible = "ti,tps65912", },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, tps65912_i2c_of_match_table);
>  
>  static int tps65912_i2c_probe(struct i2c_client *client,
>  			      const struct i2c_device_id *ids)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog