linux-kernel - Re: [PATCH v2 1/1] EDAC: kill ->show_interleave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170123120424.u24fclewbfdznf7n@pd.tnic>
Date:   Mon, 23 Jan 2017 13:04:25 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] EDAC: kill ->show_interleave_mode()

On Sun, Jan 22, 2017 at 06:28:06PM +0100, Nicolas Iooss wrote:
> Function sbridge_register_mci() sets pvt->info.show_interleave_mode to
> knl_show_interleave_mode() on Knight's Landing and
> show_interleave_mode() anywhere else. These functions are only called in
> a debug statement and knl_show_interleave_mode() implementation causes a
> compiler warning (the compiler fails to understand that the default
> branch of the switch condition can never be reached because reg is a
> 2-bit value).
> 
> Merge show_interleave_mode() and knl_show_interleave_mode() in a single
> implementation and use it without an indirect function pointer.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@....org>
> ---
>  drivers/edac/sb_edac.c | 44 ++++++++++----------------------------------
>  1 file changed, 10 insertions(+), 34 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.