linux-kernel - Re: blk-throttle: Move three assignments for the variable "ret" in tg_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <849a1dbc-f4c0-caf0-ad7e-706c08127c68@users.sourceforge.net>
Date:   Mon, 23 Jan 2017 13:06:44 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Johannes Thumshirn <jthumshirn@...e.de>,
        linux-block@...r.kernel.org
Cc:     Jens Axboe <axboe@...nel.dk>, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: blk-throttle: Move three assignments for the variable "ret" in
 tg_set_max()

>> We have got different preferences for the placement of error code settings.
> Yes we do, so what's the point? Both are OK.

Can a function implementation be executed a bit faster in the case
that error codes will usually only matter if they would be set after
a concrete software failure


> Please don't go down that road it opens so much potential for needless bikeshedding
> and waste all of our (including your) time.

I would appreciate to clarify involved run time consequences a bit more.

Regards,
Markus