lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 23 Jan 2017 08:14:38 -0700
From:   Jens Axboe <>
To:     Johannes Thumshirn <>,
        SF Markus Elfring <>
Cc:, LKML <>,
Subject: Re: [PATCH 3/5] blk-throttle: Adjust two function calls together with
 a variable assignment

On 01/23/2017 02:20 AM, Johannes Thumshirn wrote:
> On Sun, Jan 22, 2017 at 09:33:08AM +0100, SF Markus Elfring wrote:
>> From: Markus Elfring <>
>> Date: Sat, 21 Jan 2017 22:15:33 +0100
>> The script "" pointed information out like the following.
>> ERROR: do not use assignment in if condition
>> Thus fix the affected source code places.
>> Signed-off-by: Markus Elfring <>
>> ---
> Reviewed-by: Johannes Thumshirn <>
> if Jens wants doesn't mind.

I don't mind these, but I completely agree on the patches for moving the
'error' assignment. What ends up happening for those cases is that
someone adds a new section and forgets to set 'error', and then all hell
breaks lose.

So Markus, don't bother sending those patches again for the block layer
or drivers, I'm not going to take them.

Jens Axboe

Powered by blists - more mailing lists