linux-kernel - Re: [PATCH] zram: remove waitqueue for IO done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170123135724.GA438@tigerII.localdomain>
Date:   Mon, 23 Jan 2017 22:57:24 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Minchan Kim <minchan@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] zram: remove waitqueue for IO done

On (01/23/17 13:17), Minchan Kim wrote:
> zram_reset_device waits ongoing writepage pages completed by
> zram->refcount logic. However, it's pointless because before
> the reset, we prevent further opening of zram by zram->claim
> and flush all of pending IO by fsync_bdev so there should be
> no pending IO at the zram_reset_device.

interesting.
looks reasonable to me.

> Signed-off-by: Minchan Kim <minchan@...nel.org>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

	-ss