linux-kernel - Re: [PATCH] firmware/Makefile: force recompilation if makefile changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170123145952.GM13946@wotan.suse.de>
Date:   Mon, 23 Jan 2017 15:59:52 +0100
From:   "Luis R. Rodriguez" <mcgrof@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     ming.lei@...onical.com, wagi@...om.org, dwmw2@...radead.org,
        linux-kernel@...r.kernel.org, Michal Marek <mmarek@...e.com>,
        linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] firmware/Makefile: force recompilation if makefile
 changes

On Thu, Jan 19, 2017 at 11:15:07AM +0100, Greg KH wrote:
> On Wed, Jan 18, 2017 at 09:31:56AM -0800, Luis R. Rodriguez wrote:
> > If you modify the target asm we currently do not force the
> > recompilation of the firmware files. The target asm is in
> > the firmware/Makefile, peg this file as a dependency to
> > require re-compilation of firmware targets when the asm
> > changes.
> 
> Why would changing the Makefile require the asm to change?

The Makefile is the file that provides the assembly logic, so
changing the asm should affect recreating the binary.

> Anyway, this should go through the kbuild tree, not mine, they know
> Makefiles much better than I do...

Will send it there. Thanks.

  Luis