linux-kernel - Re: [PATCH 1/2] device property: export code duplicating array of property entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2017 14:46:54 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH 1/2] device property: export code duplicating array of
 property entries

On Mon, Jan 23, 2017 at 05:00:38PM +0200, Andy Shevchenko wrote:
> On Sun, 2017-01-22 at 23:38 -0800, Dmitry Torokhov wrote:
> > When augmenting ACPI-enumerated devices with additional property data
> > based
> > on DMI info, a module has often several potential property sets, with
> > only
> > one being active on a given box. In order to save memory it should be
> > possible to mark everything and __initdata or __initconst, execute DMI
> > match early, and duplicate relevant properties. Then kernel will
> > discard
> > the rest of them.
> > 
> 
> Looks good to me.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Couple of style nitpicks.
> 
> > 
> > +struct property_entry *property_entries_dup(
> > +				const struct property_entry
> > *properties)
> 
> Can we use
> 
> struct propert_entry *
> property_entries_dup(...)
> 
> ?

Sure, will adjust. I also realized we'll need property_entries_free()
for proper cleanups. I'll repost the series.

> 
> 
> > +struct property_entry *property_entries_dup(
> > +				const struct property_entry
> > *properties);
> > 
> 
> Ditto.
> 
> -- 
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Intel Finland Oy

-- 
Dmitry