linux-kernel - Re: [PATCH 1/2] device property: export code duplicating array of property entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c84a90ae-983b-4a1f-0b4d-5bf873391c0a@intel.com>
Date:   Mon, 30 Jan 2017 23:48:18 +0100
From:   "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH 1/2] device property: export code duplicating array of
 property entries

On 1/23/2017 11:46 PM, Dmitry Torokhov wrote:
> On Mon, Jan 23, 2017 at 05:00:38PM +0200, Andy Shevchenko wrote:
>> On Sun, 2017-01-22 at 23:38 -0800, Dmitry Torokhov wrote:
>>> When augmenting ACPI-enumerated devices with additional property data
>>> based
>>> on DMI info, a module has often several potential property sets, with
>>> only
>>> one being active on a given box. In order to save memory it should be
>>> possible to mark everything and __initdata or __initconst, execute DMI
>>> match early, and duplicate relevant properties. Then kernel will
>>> discard
>>> the rest of them.
>>>
>> Looks good to me.
>>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>
>> Couple of style nitpicks.
>>
>>> +struct property_entry *property_entries_dup(
>>> +				const struct property_entry
>>> *properties)
>> Can we use
>>
>> struct propert_entry *
>> property_entries_dup(...)
>>
>> ?
> Sure, will adjust. I also realized we'll need property_entries_free()
> for proper cleanups. I'll repost the series.

Can you please CC it to linux-acpi while at that?  It will help to 
handle it.

Thanks,
Rafael