linux-kernel - Re: KVM: s390: Move two error code assignments in kvm_vm_ioctl_get_dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64b94d75-6bad-1ebc-c35e-c036202bab01@redhat.com>
Date:   Tue, 24 Jan 2017 13:18:33 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        Christian Bornträger <borntraeger@...ibm.com>,
        kvm@...r.kernel.org, linux-s390@...r.kernel.org
Cc:     Cornelia Huck <cornelia.huck@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: KVM: s390: Move two error code assignments in
 kvm_vm_ioctl_get_dirty_log()



On 24/01/2017 13:10, SF Markus Elfring wrote:
>>> Would you like to check run time consequences
>>> for the shown error code settings once more?
>>
>> Sure, lets for now ignore the fact that the performance of an error path
>> does not matter most of the time.
> 
> I am concerned that extra error code settings within the “success path”
> could influence the run time behaviour in unwanted ways.
> 
> 
>> After tree building and optimization your change should not matter at all
>> regarding performance for a decent compiler.
> 
> I find your optimism interesting.

Mummy says stupid is as stupid does.  Sorry, but I'm putting you on a
kill list.  It's just not possible to discuss things with you. You're
the first person _ever_ to get this treatment in about 20 years of me
using the Internet.

If other people want to merge your patches to KVM, they are free to do so.

Paolo