[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0833bdec-b05e-57c0-c740-ac7735036450@arm.com>
Date: Wed, 25 Jan 2017 09:24:14 +0000
From: Marc Zyngier <marc.zyngier@....com>
To: Bharat Kumar Gogada <bharat.kumar.gogada@...inx.com>,
bhelgaas@...gle.com, paul.gortmaker@...driver.com, robh@...nel.org,
colin.king@...onical.com, linux-pci@...r.kernel.org
Cc: michal.simek@...inx.com, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, rgummal@...inx.com, arnd@...db.de,
Bharat Kumar Gogada <bharatku@...inx.com>
Subject: Re: [PATCH v2 2/2] PCI: Xilinx NWL: Fix, proc interrupts for legacy
virtual irq shown as edge
On 25/01/17 08:52, Bharat Kumar Gogada wrote:
> - Legacy interrupts are level triggered, virtual irq line of End
> Point shows as edge in /proc/interrupts.
> - Setting irq flags of virtual irq line of EP to level triggered
> at the time of mapping.
>
> Signed-off-by: Bharat Kumar Gogada <bharatku@...inx.com>
> ---
> drivers/pci/host/pcie-xilinx-nwl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/host/pcie-xilinx-nwl.c b/drivers/pci/host/pcie-xilinx-nwl.c
> index 6ac3e1d..1cddd1f 100644
> --- a/drivers/pci/host/pcie-xilinx-nwl.c
> +++ b/drivers/pci/host/pcie-xilinx-nwl.c
> @@ -434,6 +434,7 @@ static int nwl_legacy_map(struct irq_domain *domain, unsigned int irq,
> {
> irq_set_chip_and_handler(irq, &nwl_leg_irq_chip, handle_level_irq);
> irq_set_chip_data(irq, domain->host_data);
> + irq_set_status_flags(irq, IRQ_LEVEL);
>
> return 0;
> }
>
As said in my previous review [1], this should be folded in the previous
patch, as it doesn't make much sense on its own.
Thanks,
M.
[1] http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1316912.html
--
Jazz is not dead. It just smells funny...
Powered by blists - more mailing lists