lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 25 Jan 2017 12:47:53 +0100
From:   Michal Hocko <>
Subject: Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page

On Mon 23-01-17 22:50:10, wrote:
> From: Yisheng Xie <>
> This patch is to extends soft offlining framework to support
> non-lru page, which already support migration after
> commit bda807d44454 ("mm: migrate: support non-lru movable page
> migration")
> When memory corrected errors occur on a non-lru movable page,
> we can choose to stop using it by migrating data onto another
> page and disable the original (maybe half-broken) one.
> Signed-off-by: Yisheng Xie <>
> Suggested-by: Michal Hocko <>
> Suggested-by: Minchan Kim <>
> Acked-by: Naoya Horiguchi <>

This doesn't compile with CONFIG_MIGRATION=n

mm/memory-failure.c: In function '__soft_offline_page':
mm/memory-failure.c:1656:3: error: implicit declaration of function 'isolate_movable_page' [-Werror=implicit-function-declaration]
   ret = !isolate_movable_page(page, ISOLATE_UNEVICTABLE);
cc1: some warnings being treated as errors

I guess the following should handle the problem
diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index ae8d475a9385..1da7a1f99fc7 100644
--- a/include/linux/migrate.h
+++ b/include/linux/migrate.h
@@ -57,6 +57,11 @@ static inline int migrate_pages(struct list_head *l, new_page_t new,
 		int reason)
 	{ return -ENOSYS; }
+static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode)
+	return -EBUSY;
 static inline int migrate_prep(void) { return -ENOSYS; }
 static inline int migrate_prep_local(void) { return -ENOSYS; }
At least it compiles fine now. I have to look at the patch yet.
Michal Hocko

Powered by blists - more mailing lists