linux-kernel - Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170125115212.GK32377@dhcp22.suse.cz>
Date:   Wed, 25 Jan 2017 12:52:13 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     ysxie@...mail.com
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        n-horiguchi@...jp.nec.com, akpm@...ux-foundation.org,
        minchan@...nel.org, vbabka@...e.cz, guohanjun@...wei.com,
        qiuxishi@...wei.com
Subject: Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page

On Wed 25-01-17 12:47:53, Michal Hocko wrote:
> On Mon 23-01-17 22:50:10, ysxie@...mail.com wrote:
> > From: Yisheng Xie <xieyisheng1@...wei.com>
> > 
> > This patch is to extends soft offlining framework to support
> > non-lru page, which already support migration after
> > commit bda807d44454 ("mm: migrate: support non-lru movable page
> > migration")
> > 
> > When memory corrected errors occur on a non-lru movable page,
> > we can choose to stop using it by migrating data onto another
> > page and disable the original (maybe half-broken) one.
> > 
> > Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
> > Suggested-by: Michal Hocko <mhocko@...nel.org>
> > Suggested-by: Minchan Kim <minchan@...nel.org>
> > Acked-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
> 
> This doesn't compile with CONFIG_MIGRATION=n
> 
> mm/memory-failure.c: In function '__soft_offline_page':
> mm/memory-failure.c:1656:3: error: implicit declaration of function 'isolate_movable_page' [-Werror=implicit-function-declaration]
>    ret = !isolate_movable_page(page, ISOLATE_UNEVICTABLE);
>    ^
> cc1: some warnings being treated as errors

OK, I have missed
http://lkml.kernel.org/r/1485340563-60785-1-git-send-email-xieyisheng1@huawei.com
so please scratch this one.

-- 
Michal Hocko
SUSE Labs