linux-kernel - Re: [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58880514.6060105@intel.com>
Date:   Wed, 25 Jan 2017 09:53:24 +0800
From:   Jike Song <jike.song@...el.com>
To:     Alex Williamson <alex.williamson@...hat.com>
CC:     zhi.a.wang@...el.com, zhenyuw@...ux.intel.com,
        jani.nikula@...ux.intel.com, airlied@...ux.ie,
        intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, igvt-g-dev@...1.01.org,
        daniel.vetter@...el.com
Subject: Re: [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances,
 not available_instance

On 01/25/2017 03:53 AM, Alex Williamson wrote:
> Per the ABI specification[1], each mdev_supported_types entry should
> have an available_instances, with an "s", not available_instance.
> 
> [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev
> 
> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>
> ---
> 
> This should really be fixed before initial release in v4.10

Acked-by: Jike Song <jike.song@...el.com>

Thanks for finding this!


--
Thanks,
Jike

> 
>  drivers/gpu/drm/i915/gvt/kvmgt.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index faaae07..ab1e057 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -230,8 +230,8 @@ static struct intel_vgpu_type *intel_gvt_find_vgpu_type(struct intel_gvt *gvt,
>  	return NULL;
>  }
>  
> -static ssize_t available_instance_show(struct kobject *kobj, struct device *dev,
> -		char *buf)
> +static ssize_t available_instances_show(struct kobject *kobj,
> +					struct device *dev, char *buf)
>  {
>  	struct intel_vgpu_type *type;
>  	unsigned int num = 0;
> @@ -269,12 +269,12 @@ static ssize_t description_show(struct kobject *kobj, struct device *dev,
>  				type->fence);
>  }
>  
> -static MDEV_TYPE_ATTR_RO(available_instance);
> +static MDEV_TYPE_ATTR_RO(available_instances);
>  static MDEV_TYPE_ATTR_RO(device_api);
>  static MDEV_TYPE_ATTR_RO(description);
>  
>  static struct attribute *type_attrs[] = {
> -	&mdev_type_attr_available_instance.attr,
> +	&mdev_type_attr_available_instances.attr,
>  	&mdev_type_attr_device_api.attr,
>  	&mdev_type_attr_description.attr,
>  	NULL,
>