linux-kernel - Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1485309036.12563.46.camel@perches.com>
Date:   Tue, 24 Jan 2017 17:50:36 -0800
From:   Joe Perches <joe@...ches.com>
To:     Gideon Israel Dsouza <gidisrael@...il.com>,
        akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        gerg@...ux-m68k.org, geert@...ux-m68k.org,
        linux-m68k@...ts.linux-m68k.org
Subject: Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute

On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
> Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
> taken up, to replace gcc specific attributes with macros.
> 
> Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
> crypto: Replaced gcc specific attributes with macros from compiler.h
> 
> The last commit of this task that went through you: 52f5684c8e1ec
> kernel: use macros from compiler.h instead of __attribute__((...))
> 
> The next patch is for cleaning up the m68k subsystem and it requires
> a new macro to wrap __attribute__ ((mode (...)))
[]
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
[]
> @@ -121,6 +121,7 @@
>  #define __attribute_const__	__attribute__((__const__))
>  #define __maybe_unused		__attribute__((unused))
>  #define __always_unused		__attribute__((unused))
> +#define __mode                  __attribute__((mode(x)))

Huh?

Perhaps you meant

#define __mode(x)	__attribute__((mode(x)))

?