linux-kernel - Re: [PATCH] nvdimm: constify device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOH+1jE5F_2qL2O_iMo69y5rpTmSq-1eOKTas6_xuP8xitfWbw@mail.gmail.com>
Date:   Wed, 25 Jan 2017 21:46:45 +0530
From:   Bhumika Goyal <bhumirks@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Julia Lawall <julia.lawall@...6.fr>,
        Dan Williams <dan.j.williams@...el.com>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...1.01.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvdimm: constify device_type structures

On Wed, Jan 25, 2017 at 9:31 PM, Joe Perches <joe@...ches.com> wrote:
> On Wed, 2017-01-25 at 07:49 +0100, Julia Lawall wrote:
>> What does the data column actually represent?  I tried size on the .o file
>> generated from:
>>
>> commit a65f0161f4d69d6738d4821e649448312cd818e2
>> Author: Stephen Rothwell <sfr@...b.auug.org.au>
>> Date:   Tue Jan 17 15:22:28 2017 +1100
>>
>> with CONFIG_X86_64=y and I get:
>>
>>    text          data     bss     dec     hex filename
>>   19726          3480      16   23222    5ab6 drivers/nvdimm/namespace_devs.o
>>
>> but when I run objdump -sh drivers/nvdimm/namespace_devs.o, I find a .data
>> segment of size 1008 and a .data.unlikely segment of size 8, which don't
>> match up with the results of size.
>
> Likely you have dynamic_debug enabled and you
> need to include these additional sections:
>
>         __jump_table
>         __verbose
>
> If user_mode_linux is enabled, add sections:
>
>         .fini_array
>         .init_array
>

Thanks for the explanation. I also compiled the patch for x86-64 but
couldn't find what went wrong but this solved the problem.

Thanks,
Bhumika