linux-kernel - Re: [PATCH v3] i2c: core: helper function to detect slave mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170125210118.z5o6y6aurwic4zxc@ninjato>
Date:   Wed, 25 Jan 2017 22:01:19 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Luis Oliveira <Luis.Oliveira@...opsys.com>, robh+dt@...nel.org,
        mark.rutland@....com, jarkko.nikula@...ux.intel.com,
        mika.westerberg@...ux.intel.com, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        vz@...ia.com, Ramiro.Oliveira@...opsys.com,
        Joao.Pinto@...opsys.com, CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH v3] i2c: core: helper function to detect slave mode

On Wed, Jan 25, 2017 at 10:50:09PM +0200, Andy Shevchenko wrote:
> On Wed, 2017-01-25 at 21:45 +0100, Wolfram Sang wrote:
> > > + * i2c_slave_mode_detect - detect operation mode
> > 
> > I'd rather name it 'i2c_detect_slave_mode'
> 
> When I proposed that I kept in ming `git grep -n i2c_slave`.

"i2c.*slave"? :)

I think having the verb first makes function names more comprehensible.
i2c-core is not super consistent with that, but I'd say more follow this
than not.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)