linux-kernel - Re: [PATCH v3] i2c: core: helper function to detect slave mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfaG96BgwM2S6Mw3Uv=DcLrV1id7nyMzrk9xSreT_ZAEw@mail.gmail.com>
Date:   Wed, 25 Jan 2017 23:29:39 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Luis Oliveira <Luis.Oliveira@...opsys.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c@...r.kernel.org, devicetree <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Ramiro.Oliveira@...opsys.com, Joao Pinto <Joao.Pinto@...opsys.com>,
        CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH v3] i2c: core: helper function to detect slave mode

On Wed, Jan 25, 2017 at 11:01 PM, Wolfram Sang <wsa@...-dreams.de> wrote:
> On Wed, Jan 25, 2017 at 10:50:09PM +0200, Andy Shevchenko wrote:
>> On Wed, 2017-01-25 at 21:45 +0100, Wolfram Sang wrote:
>> > > + * i2c_slave_mode_detect - detect operation mode
>> >
>> > I'd rather name it 'i2c_detect_slave_mode'
>>
>> When I proposed that I kept in ming `git grep -n i2c_slave`.
>
> "i2c.*slave"? :)

'i2c[a-z_]\+slave'

> I think having the verb first makes function names more comprehensible.
> i2c-core is not super consistent with that, but I'd say more follow this
> than not.

I'm okay with either.

-- 
With Best Regards,
Andy Shevchenko