linux-kernel - Re: [PATCHv4] mfd: cpcap: Add minimal support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170125224114.GK7403@atomide.com>
Date:   Wed, 25 Jan 2017 14:41:16 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        Marcel Partap <mpartap@....net>,
        Mark Rutland <mark.rutland@....com>,
        Michael Scott <michael.scott@...aro.org>
Subject: Re: [PATCHv4] mfd: cpcap: Add minimal support

* Lee Jones <lee.jones@...aro.org> [170124 01:32]:
> On Thu, 05 Jan 2017, Tony Lindgren wrote:
> > +
> > +	bit = irq % cpcap->regmap_conf->val_bits;
> > +	mask = (1 << bit);
> 
> Nit: BIT()
...
> > + * Copyright (C) 2016 Tony Lindgren <tony@...mide.com>
> 
> Nit: 2017
...
> > +/*
> > + * Helpers for child devices to check the revision and vendor.
> > + *
> > + * REVISIT: No documentation for the bits below, please update
> > + * to use proper names for defines when available.
> > + */
> 
> Yes, please do that.
> 
> But you can do all of the above with subsequent patches.

OK I'll send you a BIT() follow-up patch.

> Applied, thanks.

Thanks, not seeing it in next or mfd git tree yet though, forgot
to push out?

Regards,

Tony