linux-kernel - Re: [PATCH] x86/crypto: fix %progbits -> @progbits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ad0ec8d-a7d2-b4ca-df7d-3b670b468baf@zytor.com>
Date:   Wed, 25 Jan 2017 14:37:08 -0800
From:   "H. Peter Anvin" <hpa@...or.com>
To:     Denys Vlasenko <dvlasenk@...hat.com>,
        Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Josh Poimboeuf <jpoimboe@...hat.com>,
        Xiaodong Liu <xiaodong.liu@...el.com>,
        Megha Dey <megha.dey@...el.com>,
        George Spelvin <linux@...izon.com>,
        linux-crypto@...r.kernel.org, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/crypto: fix %progbits -> @progbits

On 01/19/17 13:28, Denys Vlasenko wrote:
> %progbits form is used on ARM (where @ is a comment char).
> 
> x86 consistently uses @progbits everywhere else.

However, it looks like %progbits works on all architectures (at least
include/linux/init.h seems to imply so.)  Perhaps a tree-wide
replacement the other way would make more sense.

Personally I would also like to see these parameters macroized, to keep
someone from getting them wrong, just like we have __INIT, __INITRODATA
etc already, we should just have plain __TEXT __DATA __BSS...

	-hpa