[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdZW1CEmn-bKYNY_gExkMSS1CtA5ggR-ULz=xDe9j8JMqg@mail.gmail.com>
Date: Thu, 26 Jan 2017 11:31:01 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
Linux Input <linux-input@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Hans de Goede <hdegoede@...hat.com>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH 04/13] Input: keyboard - Use local variables consistently
On Sat, Jan 21, 2017 at 7:45 PM, Guenter Roeck <linux@...ck-us.net> wrote:
> If a function declares a variable to access a structure element,
> use it conssistently.
Weird spelling :)
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> - error = devm_gpio_request_one(&pdev->dev, button->gpio, flags,
> - desc);
> + error = devm_gpio_request_one(dev, button->gpio, flags, desc);
I think I have changes in the GPIO tree touching these code sites.
I put those on an immutable branch so Dmitry can pull it if he needs
it as a base for this patch:
https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/commit/?h=ib-gpiod-flags
Yours,
Linus Walleij
Powered by blists - more mailing lists