linux-kernel - Re: [PATCH 04/13] Input: keyboard - Use local variables consistently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa619844-70aa-5b62-8ecd-f15440451cec@roeck-us.net>
Date:   Thu, 26 Jan 2017 06:28:37 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Linux Input <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Hans de Goede <hdegoede@...hat.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH 04/13] Input: keyboard - Use local variables consistently

On 01/26/2017 02:31 AM, Linus Walleij wrote:
> On Sat, Jan 21, 2017 at 7:45 PM, Guenter Roeck <linux@...ck-us.net> wrote:
>
>> If a function declares a variable to access a structure element,
>> use it conssistently.
>
> Weird spelling :)
>
Call id sssnaky :-)

Guenter

>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>
>> -               error = devm_gpio_request_one(&pdev->dev, button->gpio, flags,
>> -                                             desc);
>> +               error = devm_gpio_request_one(dev, button->gpio, flags, desc);
>
> I think I have changes in the GPIO tree touching these code sites.
>
> I put those on an immutable branch so Dmitry can pull it if he needs
> it as a base for this patch:
> https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/commit/?h=ib-gpiod-flags
>
> Yours,
> Linus Walleij
>