[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170126124157.GB7785@mobilestation>
Date: Thu, 26 Jan 2017 15:41:57 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Wei Yongjun <weiyj.lk@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Wei Yongjun <weiyongjun1@...wei.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] eeprom: idt_89hpesx: Drop kfree for memory
allocated with devm_kzalloc
On Wed, Jan 25, 2017 at 02:09:52PM +0000, Wei Yongjun <weiyj.lk@...il.com> wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> It's not necessary to free memory allocated with devm_kzalloc
> and using kfree leads to a double free.
>
> Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
> drivers/misc/eeprom/idt_89hpesx.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
> index 25d47d0..f5f2c5a 100644
> --- a/drivers/misc/eeprom/idt_89hpesx.c
> +++ b/drivers/misc/eeprom/idt_89hpesx.c
> @@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
> pdev->ee_file->size = pdev->eesize;
> ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
> if (ret != 0) {
> - kfree(pdev->ee_file);
> dev_err(dev, "Failed to create EEPROM sysfs-node");
> return ret;
> }
> @@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
>
> /* Remove EEPROM sysfs file */
> sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
> -
> - /* Free memory allocated for bin_attribute structure */
> - kfree(pdev->ee_file);
> }
>
> /*
>
True point! Thanks for the patch.
Acked-by: Serge Semin <fancer.lancer@...il.com>
Powered by blists - more mailing lists