linux-kernel - Re: [patch] eeprom/idt_89hpesx: freeing devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170126124416.GC7785@mobilestation>
Date:   Thu, 26 Jan 2017 15:44:16 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree()

On Thu, Jan 26, 2017 at 12:01:46PM +0300, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> "pdev->ee_file" was allocated with devm_kmalloc() so freeing it with
> kfree() is a double free.  In fact, we don't need to free it at all.
> 
> Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
> index 25d47d09e1cb..f5f2c5a8d9b0 100644
> --- a/drivers/misc/eeprom/idt_89hpesx.c
> +++ b/drivers/misc/eeprom/idt_89hpesx.c
> @@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
>  	pdev->ee_file->size = pdev->eesize;
>  	ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
>  	if (ret != 0) {
> -		kfree(pdev->ee_file);
>  		dev_err(dev, "Failed to create EEPROM sysfs-node");
>  		return ret;
>  	}
> @@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
>  
>  	/* Remove EEPROM sysfs file */
>  	sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
> -
> -	/* Free memory allocated for bin_attribute structure */
> -	kfree(pdev->ee_file);
>  }
>  
>  /*

Just got the same patch a day earlier, but still thanks for the pointing the issue out.

Regards,
-Sergey