linux-kernel - [tip:perf/core] perf probe: Delete an unnecessary check in try_to_find_absolute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-42e233cacc052bd545417c68155f2b9abd1bab72@git.kernel.org>
Date:   Thu, 26 Jan 2017 07:28:39 -0800
From:   tip-bot for Markus Elfring <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     wangnan0@...wei.com, ravi.bangoria@...ux.vnet.ibm.com,
        acme@...hat.com, peterz@...radead.org, hekuang@...wei.com,
        alexander.shishkin@...ux.intel.com, mingo@...nel.org,
        milian.wolff@...b.com, elfring@...rs.sourceforge.net,
        mhiramat@...nel.org, hpa@...or.com, adrian.hunter@...el.com,
        jolsa@...nel.org, linux-kernel@...r.kernel.org, tglx@...utronix.de
Subject: [tip:perf/core] perf probe: Delete an unnecessary check in
 try_to_find_absolute_address()

Commit-ID:  42e233cacc052bd545417c68155f2b9abd1bab72
Gitweb:     http://git.kernel.org/tip/42e233cacc052bd545417c68155f2b9abd1bab72
Author:     Markus Elfring <elfring@...rs.sourceforge.net>
AuthorDate: Mon, 23 Jan 2017 14:54:26 +0100
Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Thu, 26 Jan 2017 11:42:55 -0300

perf probe: Delete an unnecessary check in try_to_find_absolute_address()

Remove a condition check which is unnecessary at the end
because this source code place should usually only be reached
with a non-zero pointer.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
Acked-by: Masami Hiramatsu <mhiramat@...nel.org>
Cc: Adrian Hunter <adrian.hunter@...el.com>
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc: He Kuang <hekuang@...wei.com>
Cc: Jiri Olsa <jolsa@...nel.org>
Cc: Milian Wolff <milian.wolff@...b.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Cc: Wang Nan <wangnan0@...wei.com>
Cc: kernel-janitors@...r.kernel.org
Link: http://lkml.kernel.org/r/a3f2473b-6383-a326-bce0-b826423608b8@users.sourceforge.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/util/probe-event.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 4a57c8a..cdfc468 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -3004,10 +3004,8 @@ static int try_to_find_absolute_address(struct perf_probe_event *pev,
 	return 1;
 
 errout:
-	if (*tevs) {
-		clear_probe_trace_events(*tevs, 1);
-		*tevs = NULL;
-	}
+	clear_probe_trace_events(*tevs, 1);
+	*tevs = NULL;
 	return err;
 }