linux-kernel - Re: [PATCH v2] sound: pci: cs46xx: constify snd_pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hefzpiza5.wl-tiwai@suse.de>
Date:   Thu, 26 Jan 2017 17:03:46 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Bhumika Goyal" <bhumirks@...il.com>
Cc:     <alsa-devel@...a-project.org>, <julia.lawall@...6.fr>,
        <perex@...ex.cz>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] sound: pci: cs46xx: constify snd_pcm_ops structures

On Thu, 26 Jan 2017 16:41:05 +0100,
Bhumika Goyal wrote:
> 
> Declare snd_pcm_ops structures as const as they are either stored in the
> ops field of a snd_pcm_substream structure or passed as an argument to
> the function snd_pcm_set_ops. The function argument and the ops field
> are of type const, so snd_pcm_ops structures having this property
> can be made const too.
> 
> File size before: sound/pci/cs46xx/cs46xx_lib.o
>    text	   data	    bss	    dec	    hex	filename
>   26047	   5304	     16	  31367	   7a87	sound/pci/cs46xx/cs46xx_lib.o
> 
> File size after: sound/pci/cs46xx/cs46xx_lib.o
>    text	   data	    bss	    dec	    hex	filename
>   27335	   4036	     16	  31387	   7a9b	sound/pci/cs46xx/cs46xx_lib.o
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
> Changes in v2:
> * test build the patch with CONFIG_SND_CS46XX_NEW_DSP=y

Applied, thanks.


Takashi