linux-kernel - Re: [PATCH 2/7] x86/fpu: Simplify fpu->fpregs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrUDCBC3HQAL8mpDrj+qoH+R5r-p+jw9hMX9PZGeXGT2cQ@mail.gmail.com>
Date:   Thu, 26 Jan 2017 08:30:33 -0800
From:   Andy Lutomirski <luto@...capital.net>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Rik van Riel <riel@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>
Subject: Re: [PATCH 2/7] x86/fpu: Simplify fpu->fpregs_active use

On Thu, Jan 26, 2017 at 3:26 AM, Ingo Molnar <mingo@...nel.org> wrote:
> The fpregs_active() inline function is pretty pointless - in almost
> all the callsites it can be replaced with a direct fpu->fpregs_active
> access.
>
> Do so and eliminate the extra layer of obfuscation.

Reviewed-by: Andy Lutomirski <luto@...nel.org>