linux-kernel - Re: [PATCH] sound: pci: cs46xx: constify snd_pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 27 Jan 2017 00:48:39 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     kbuild-all@...org, julia.lawall@...6.fr, perex@...ex.cz,
        tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, Bhumika Goyal <bhumirks@...il.com>
Subject: Re: [PATCH] sound: pci: cs46xx: constify snd_pcm_ops structures

Hi Bhumika,

[auto build test ERROR on sound/for-next]
[also build test ERROR on v4.10-rc5 next-20170125]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Bhumika-Goyal/sound-pci-cs46xx-constify-snd_pcm_ops-structures/20170126-230341
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the linux-review/Bhumika-Goyal/sound-pci-cs46xx-constify-snd_pcm_ops-structures/20170126-230341 HEAD 59da8ce3cc92652020c8c6a3ad0a4b11d8ee5a48 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

>> sound/pci/cs46xx/cs46xx_lib.c:1657:27: error: conflicting type qualifiers for 'snd_cs46xx_playback_rear_ops'
    static struct snd_pcm_ops snd_cs46xx_playback_rear_ops = {
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   sound/pci/cs46xx/cs46xx_lib.c:75:33: note: previous declaration of 'snd_cs46xx_playback_rear_ops' was here
    static const struct snd_pcm_ops snd_cs46xx_playback_rear_ops;
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/snd_cs46xx_playback_rear_ops +1657 sound/pci/cs46xx/cs46xx_lib.c

^1da177e Linus Torvalds 2005-04-16  1651  	chip->active_ctrl(chip, -1);
^1da177e Linus Torvalds 2005-04-16  1652  
^1da177e Linus Torvalds 2005-04-16  1653  	return 0;
^1da177e Linus Torvalds 2005-04-16  1654  }
^1da177e Linus Torvalds 2005-04-16  1655  
^1da177e Linus Torvalds 2005-04-16  1656  #ifdef CONFIG_SND_CS46XX_NEW_DSP
3d19f804 Takashi Iwai   2005-11-17 @1657  static struct snd_pcm_ops snd_cs46xx_playback_rear_ops = {
^1da177e Linus Torvalds 2005-04-16  1658  	.open =			snd_cs46xx_playback_open_rear,
^1da177e Linus Torvalds 2005-04-16  1659  	.close =		snd_cs46xx_playback_close,
^1da177e Linus Torvalds 2005-04-16  1660  	.ioctl =		snd_pcm_lib_ioctl,

:::::: The code at line 1657 was first introduced by commit
:::::: 3d19f804ef5f1d15fe001fc8d1ed58fac9d591fb [ALSA] Remove xxx_t typedefs: PCI CS46xx

:::::: TO: Takashi Iwai <tiwai@...e.de>
:::::: CC: Jaroslav Kysela <perex@...e.cz>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (38270 bytes)