linux-kernel - Re: ibmvtpm byteswapping inconsistency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMqctQGoa_A9pCppWaDoudmvfgfVe3Vpg+OmUneF4vJ_8xqkg@mail.gmail.com>
Date:   Thu, 26 Jan 2017 23:43:27 +0100
From:   Michal Suchanek <hramrach@...il.com>
To:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:     "Michal Such??nek" <msuchanek@...e.de>,
        Nayna Jain <nayna@...ux.vnet.ibm.com>,
        Ashley Lai <ashleydlai@...il.com>,
        Marcel Selhorst <tpmdd@...horst.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        tpmdd-devel@...ts.sourceforge.net,
        Paul Mackerras <paulus@...ba.org>,
        Peter Huewe <peterhuewe@....de>, linuxppc-dev@...ts.ozlabs.org
Subject: Re: ibmvtpm byteswapping inconsistency

On 26 January 2017 at 23:05, Jason Gunthorpe
<jgunthorpe@...idianresearch.com> wrote:
> On Thu, Jan 26, 2017 at 09:22:48PM +0100, Michal Such??nek wrote:
>
>> This is repeated a few times in the driver so I added memset to quiet
>> gcc and make behavior deterministic in case the unused fields get some
>> meaning in the future.
>
> Yep, reserved certainly needs to be zeroed.. Can you send a patch?

And len and data as well..

> memset is overkill...

Does not look so.

Michal