linux-kernel - Re: [PATCH v2] clk: hisilicon: fix lock assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170127001846.GV8801@codeaurora.org>
Date:   Thu, 26 Jan 2017 16:18:46 -0800
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Leo Yan <leo.yan@...aro.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guodong Xu <guodong.xu@...aro.org>,
        Haojian Zhuang <haojian.zhuang@...aro.org>,
        John Stultz <john.stultz@...aro.org>
Subject: Re: [PATCH v2] clk: hisilicon: fix lock assignment

On 01/21, Leo Yan wrote:
> In clock driver initialize phase the spinlock is missed to assignment
> to struct clkgate_separated, finally there have no locking to protect
> exclusive accessing for clock registers.
> 
> This bug introduces the console has no output after enable coresight
> driver on 96boards Hikey; this is because console using UART3, which
> has shared the same register with coresight clock enabling bit. After
> applied this patch it can assign lock properly to protect exclusive
> accessing, and console can work well after enabled coresight modules.
> 
> Fixes: 0aa0c95f743a ("clk: hisilicon: add common clock support")
> Signed-off-by: Leo Yan <leo.yan@...aro.org>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project