linux-kernel - Re: [PATCH v4 10/13] arm64: allwinner: a64: Increase the MMC max frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170127212611.rn2nr4fihshud2qg@lukather>
Date:   Fri, 27 Jan 2017 22:26:11 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Florian Vaussard <florian.vaussard@...g-vd.ch>
Cc:     Chen-Yu Tsai <wens@...e.org>, Ulf Hansson <ulf.hansson@...aro.org>,
        devicetree@...r.kernel.org,
        Andre Przywara <andre.przywara@....com>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 10/13] arm64: allwinner: a64: Increase the MMC max
 frequency

On Fri, Jan 27, 2017 at 11:29:53AM +0100, Florian Vaussard wrote:
> Hi Maxime,
> 
> On 01/26/2017 10:06 AM, Maxime Ripard wrote:
> > The eMMC controller seem to have a maximum frequency of 200MHz, while the
> > regular MMC controllers are capped at 150MHz.
> > 
> > Since older SoCs cannot go that high, we cannot change the default maximum
> > frequency, but fortunately for us we have a property for that in the DT.
> > 
> > This also has the side effect of allowing to use the MMC HS200 and SD
> > SDR104 modes for the boards that support it (with either 1.2v or 1.8v IOs).
> > 
> > Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> > 
> > arm64: allwinner: a64: Limit MMC0 and MMC1 rates to 150MHz
> > 
> > Trying to set the bus to 200MHz on MMC1 when doing SDIO is failing.
> > Allwinner sets the maximum for this bus to 150MHz, so enforce that limit.
> > 
> > This hasn't been tested with MMC0, but the documented limit is the same,
> > and I expect the behaviour to be the same.
> > 
> > Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> 
> I suspect that you are trying to increase your number of Signed-off-by tags by
> using unfair means :) Otherwise the squashed commit message is probably worth
> some cleaning.

/me hides in a corner...

The first commit log is the right one, I'll remove the second.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)