[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3616490.5RPja2j5kp@phil>
Date: Sun, 29 Jan 2017 21:30:13 +0100
From: Heiko Stuebner <heiko@...ech.de>
To: Alexander Kochetkov <al.kochet@...il.com>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
LKML <linux-kernel@...r.kernel.org>, devicetree@...r.kernel.org,
LAK <linux-arm-kernel@...ts.infradead.org>,
linux-rockchip@...ts.infradead.org,
Thomas Gleixner <tglx@...utronix.de>,
Mark Rutland <mark.rutland@....com>,
Rob Herring <robh+dt@...nel.org>,
Russell King <linux@...linux.org.uk>,
Caesar Wang <wxt@...k-chips.com>,
Huang Tao <huangtao@...k-chips.com>
Subject: Re: [PATCH v5 5/8] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device
Hi Alexander,
Am Dienstag, 24. Januar 2017, 18:16:20 CET schrieb Alexander Kochetkov:
> > 24 янв. 2017 г., в 18:02, Heiko Stübner <heiko@...ech.de> написал(а):
> >
> > Please don't add Reviewed-by tags without explicit mention of them by
> > reviewers. (Also it's spelled wrong).
> >
> > I haven't looked that deeply into the driver itself and the changes made
> > to
> > feel comfortable with a "Reviewed-by".
>
> Than I posted another linux code I was asked to add such tags (and others)
> to add credits to people.
>
> Sorry for that.
no problem. In general people reviewing patches will respond to the patch with
tags they are comfortable with being added. And a Reviewed-by is a pretty
strong tag, indicating that some thought went into reviewing a specific patch,
which I hadn't done with my cursory glance at the time :-)
Heiko
Powered by blists - more mailing lists