linux-kernel - Re: [PATCH v13 2/5] iio: adc: mxs-lradc: Add support for adc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Jan 2017 00:35:14 +0100 (CET)
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Ksenija Stanojevic <ksenija.stanojevic@...il.com>
Cc:     lee.jones@...aro.org, linux-input@...r.kernel.org,
        pmeerw@...erw.net, jic23@...nel.org, knaack.h@....de,
        lars@...afoo.de, linux-kernel@...r.kernel.org,
        dmitry.torokhov@...il.com, harald@...ib.org,
        fabio.estevam@...escale.com, linux-iio@...r.kernel.org,
        marex@...x.de
Subject: Re: [PATCH v13 2/5] iio: adc: mxs-lradc: Add support for adc driver

Hi Ksenija,

> Ksenija Stanojevic <ksenija.stanojevic@...il.com> hat am 29. Januar 2017 um 19:04 geschrieben:
> 
> 
> Add support for sixteen-channel 12-bit resolution ADC and its functions,
> which include general-purpose ADC readings, battery voltage measurement,
> and die temperature measurement.
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@...il.com>
> Reviewed-by: Jonathan Cameron <jic23@...nel.org>
> Reviewed-by: Marek Vasut <marex@...x.de>
> ---
> ...
> diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c
> new file mode 100644
> index 0000000..cc8d6af
> --- /dev/null
> +++ b/drivers/iio/adc/mxs-lradc-adc.c
> @@ -0,0 +1,843 @@
> ...
> +
> +#define SHOW_SCALE_AVAILABLE_ATTR(ch)					\
> +static IIO_DEVICE_ATTR(in_voltage##ch##_scale_available, S_IRUGO,	\
> +		       mxs_lradc_adc_show_scale_avail, NULL, ch)
> +

checkpatch complains here:

ERROR: Macros with complex values should be enclosed in parentheses
#498: FILE: drivers/iio/adc/mxs-lradc-adc.c:343:
+#define SHOW_SCALE_AVAILABLE_ATTR(ch)					\
+static IIO_DEVICE_ATTR(in_voltage##ch##_scale_available, S_IRUGO,	\
+		       mxs_lradc_adc_show_scale_avail, NULL, ch)

WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#499: FILE: drivers/iio/adc/mxs-lradc-adc.c:344:
+static IIO_DEVICE_ATTR(in_voltage##ch##_scale_available, S_IRUGO,	\

total: 1 errors, 2 warnings, 869 lines checked

But the iio values on Olinuxino Maxi looks good.

Tested-by: Stefan Wahren <stefan.wahren@...e.com>