linux-kernel - Re: [PATCH v13 3/5] input: touchscreen: mxs-lradc: Add support for touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Jan 2017 00:55:09 +0100 (CET)
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Ksenija Stanojevic <ksenija.stanojevic@...il.com>
Cc:     lee.jones@...aro.org, linux-input@...r.kernel.org,
        pmeerw@...erw.net, jic23@...nel.org, knaack.h@....de,
        lars@...afoo.de, linux-kernel@...r.kernel.org,
        dmitry.torokhov@...il.com, harald@...ib.org,
        fabio.estevam@...escale.com, linux-iio@...r.kernel.org,
        marex@...x.de
Subject: Re: [PATCH v13 3/5] input: touchscreen: mxs-lradc: Add support for
 touchscreen

Hi Ksenija,

> Ksenija Stanojevic <ksenija.stanojevic@...il.com> hat am 29. Januar 2017 um 19:04 geschrieben:
> 
> 
> Add 4-wire/5-wire touchscreen controller.

i compiled all 3 driver as a module and kept the devicetree for the Olinuxino iMX233 [1] as it is (no touchscreen). After booting all 3 driver are loaded:

Module                  Size  Used by
mxs_lradc_adc          11000  0
industrialio_triggered_buffer     2628  1 mxs_lradc_adc
kfifo_buf               3337  1 industrialio_triggered_buffer
mxs_lradc_ts            4192  0
mxs_lradc               4402  0
mfd_core                4612  1 mxs_lradc

But the touchscreen driver threw this error:

[  427.230000] mxs-lradc-ts: probe of mxs-lradc-ts failed with error -22

I didn't expect this behavior. I expect that the touchscreen driver notice that there isn't a touchscreen property and abort probing silently. Also i didn't expected that the driver is still loaded in case of a probe error.

Btw shouldn't be the mxs_lradc_adc "Used by" mxs_lradc?

Because "modprobe -r mxs_lradc" doesn't unload mxs_lradc_adc.

[1] - http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx23-olinuxino.dts