linux-kernel - Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170130114105.GA4290@in.ibm.com>
Date:   Mon, 30 Jan 2017 17:11:05 +0530
From:   Gautham R Shenoy <ego@...ux.vnet.ibm.com>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        "Gautham R. Shenoy" <ego@...ux.vnet.ibm.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Michael Neuling <mikey@...ling.org>,
        Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>,
        "Shreyas B. Prabhu" <shreyasbp@...il.com>,
        Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>,
        Stewart Smith <stewart@...ux.vnet.ibm.com>,
        Balbir Singh <bsingharora@...il.com>,
        "Oliver O'Halloran" <oohall@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate
 powernv idle states.

On Mon, Jan 30, 2017 at 10:17:50PM +1100, Michael Ellerman wrote:
> "Rafael J. Wysocki" <rafael@...nel.org> writes:
> 
> > On Mon, Jan 30, 2017 at 4:47 AM, Michael Ellerman <mpe@...erman.id.au> wrote:
> >> "Gautham R. Shenoy" <ego@...ux.vnet.ibm.com> writes:
> >>
> >>> From: "Gautham R. Shenoy" <ego@...ux.vnet.ibm.com>
> >>>
> >>> In the current code for powernv_add_idle_states, there is a lot of code
> >>> duplication while initializing an idle state in powernv_states table.
> >>>
> >>> Add an inline helper function to populate the powernv_states[] table
> >>> for a given idle state. Invoke this for populating the "Nap",
> >>> "Fastsleep" and the stop states in powernv_add_idle_states.
> >>>
> >>> Acked-by: Balbir Singh <bsingharora@...il.com>
> >>> Signed-off-by: Gautham R. Shenoy <ego@...ux.vnet.ibm.com>
> >>> ---
> >>>  drivers/cpuidle/cpuidle-powernv.c | 89 +++++++++++++++++++++++----------------
> >>>  include/linux/cpuidle.h           |  1 +
> >>
> >> I was going to merge this, but I see you've touched cpuidle.h, so I feel
> >> like I should get an ACK from the cpuidle folks.
> >>
> >> It's a fairly uncontroversial change, but it's their API.
> >
> > OK, please add an ACK from me to it then.
> 
> Thanks.

Thanks Rafael and Michal.

> 
> cheers
> 
--
Thanks and Regards
gautham.