linux-kernel - Re: [PATCH v2 2/2] iio: distance: add devantech us ranger srf04

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1701310816520.1494@pmeerw.net>
Date:   Tue, 31 Jan 2017 08:19:16 +0100 (CET)
From:   Peter Meerwald-Stadler <pmeerw@...erw.net>
To:     Jonathan Cameron <jic23@...nel.org>
cc:     Andreas Klinger <ak@...klinger.de>, lars@...afoo.de,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH v2 2/2] iio: distance: add devantech us ranger srf04


> > +	indio_dev->num_channels = ARRAY_SIZE(srf04_chan_spec);
> > +
> > +	return iio_device_register(indio_dev);
> > +}
> > +
> > +static int srf04_remove(struct platform_device *pdev)
> > +{
> > +	struct iio_dev *indio_dev = platform_get_drvdata(pdev);
> > +
> > +	iio_device_unregister(indio_dev);
> With nothing else in here, you can use devm_iio_device_register
> and drop the remove entirely.

can devm_request_irq() and devm_iio_device_register() be used together?
if both are devm_ we cant't guarantee that iio_device_unregister() comes 
first in _remove()?

these devm_ things...

> > +
> > +	return 0;
> > +}
> > +
> > +static const struct of_device_id of_srf04_match[] = {
> > +	{ .compatible = "devantech,srf04", },
> > +	{},
> > +};
> > +
> > +MODULE_DEVICE_TABLE(of, of_srf04_match);
> > +
> > +static struct platform_driver srf04_driver = {
> > +	.probe		= srf04_probe,
> > +	.remove		= srf04_remove,
> > +	.driver		= {
> > +		.name		= "srf04-gpio",
> > +		.of_match_table	= of_srf04_match,
> > +	},
> > +};
> > +
> > +module_platform_driver(srf04_driver);
> > +
> > +MODULE_AUTHOR("Andreas Klinger <ak@...klinger.de>");
> > +MODULE_DESCRIPTION("SRF04 ultrasonic sensor for distance measuring using GPIOs");
> > +MODULE_LICENSE("GPL");
> > +MODULE_ALIAS("platform:srf04");
> > 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 

Peter Meerwald-Stadler
+43-664-2444418 (mobile)