linux-kernel - Re: [PATCH v3 3/5] serdev: Introduce new bus for serial attached devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Jan 2017 15:31:43 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Jiri Slaby <jslaby@...e.com>, Arnd Bergmann <arnd@...db.de>,
        "Dr . H . Nikolaus Schaller" <hns@...delico.com>,
        Peter Hurley <peter@...leysoftware.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Alan Cox <gnomes@...rguk.ukuu.org.uk>,
        Loic Poulain <loic.poulain@...el.com>,
        Pavel Machek <pavel@....cz>, NeilBrown <neil@...wn.name>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-bluetooth@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/5] serdev: Introduce new bus for serial attached
 devices

Hi Rob,

On Wed, Jan 25, 2017 at 02:23:41PM -0600, Rob Herring wrote:
> diff --git a/include/linux/serdev.h b/include/linux/serdev.h
> new file mode 100644
> index 000000000000..4f8f76d02ca8
> --- /dev/null
> +++ b/include/linux/serdev.h
>
> [...]
>
> +#ifdef CONFIG_SERIAL_DEV_BUS
>
> [method definitions]
>
> #else
>
> [method stubs]
>
> #endif
>
> [...]

This should also test for SERIAL_DEV_BUS=m, so use

#if IS_ENABLED(CONFIG_SERIAL_DEV_BUS)

(This was found by the kbuild test robot)

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)