linux-kernel - Re: [PATCH 2/3] drm/etnaviv: Update etnaviv_gem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1485941168.21479.38.camel@pengutronix.de>
Date:   Wed, 01 Feb 2017 10:26:08 +0100
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Liviu Dudau <liviu@...au.co.uk>
Cc:     David Airlie <airlied@...ux.ie>,
        Russell King <linux+etnaviv@...linux.org.uk>,
        Christian Gmeiner <christian.gmeiner@...il.com>,
        etnaviv@...ts.freedesktop.org,
        DRI devel <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Dave Jiang <dave.jiang@...el.com>
Subject: Re: [PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration
 to match definition.

Hi Liviu,

Am Dienstag, den 31.01.2017, 18:58 +0000 schrieb Liviu Dudau:
> Commit 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite
> to take only vmf") updated the etnaviv_gem_fault() function signature
> without updating the header file with the declaration.
> 
There is already a patch from Arnd on the list that fixes this issue.

https://lkml.org/lkml/2017/1/25/718

Regards,
Lucas

> Fixes: 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite to take only vmf")
> Cc: Dave Jiang <dave.jiang@...el.com>
> Cc: Lucas Stach <l.stach@...gutronix.de>
> Cc: Russell King <linux+etnaviv@...linux.org.uk>
> Cc: Christian Gmeiner <christian.gmeiner@...il.com>
> Signed-off-by: Liviu Dudau <liviu@...au.co.uk>
> ---
>  drivers/gpu/drm/etnaviv/etnaviv_drv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
> index c255eda40526..e41f38667c1c 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
> @@ -73,7 +73,7 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
>  		struct drm_file *file);
>  
>  int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma);
> -int etnaviv_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf);
> +int etnaviv_gem_fault(struct vm_fault *vmf);
>  int etnaviv_gem_mmap_offset(struct drm_gem_object *obj, u64 *offset);
>  struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj);
>  void *etnaviv_gem_prime_vmap(struct drm_gem_object *obj);