linux-kernel - Re: [PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration to match definition.

Open Source and information security mailing list archives

Message-ID: <20170201094556.GM3140@e110455-lin.cambridge.arm.com>
Date:   Wed, 1 Feb 2017 09:45:56 +0000
From:   Liviu Dudau <Liviu.Dudau@....com>
To:     Lucas Stach <l.stach@...gutronix.de>
Cc:     Liviu Dudau <liviu@...au.co.uk>, Dave Jiang <dave.jiang@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        DRI devel <dri-devel@...ts.freedesktop.org>,
        etnaviv@...ts.freedesktop.org,
        Russell King <linux+etnaviv@...linux.org.uk>
Subject: Re: [PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration
 to match definition.

On Wed, Feb 01, 2017 at 10:26:08AM +0100, Lucas Stach wrote:
> Hi Liviu,
> 
> Am Dienstag, den 31.01.2017, 18:58 +0000 schrieb Liviu Dudau:
> > Commit 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite
> > to take only vmf") updated the etnaviv_gem_fault() function signature
> > without updating the header file with the declaration.
> > 
> There is already a patch from Arnd on the list that fixes this issue.

Sorry, my search-fu was not strong enough. Thanks for pointing it out.

Best regards,
Liviu

> 
> https://lkml.org/lkml/2017/1/25/718
> 
> Regards,
> Lucas
> 
> > Fixes: 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite to take only vmf")
> > Cc: Dave Jiang <dave.jiang@...el.com>
> > Cc: Lucas Stach <l.stach@...gutronix.de>
> > Cc: Russell King <linux+etnaviv@...linux.org.uk>
> > Cc: Christian Gmeiner <christian.gmeiner@...il.com>
> > Signed-off-by: Liviu Dudau <liviu@...au.co.uk>
> > ---
> >  drivers/gpu/drm/etnaviv/etnaviv_drv.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
> > index c255eda40526..e41f38667c1c 100644
> > --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h
> > +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
> > @@ -73,7 +73,7 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
> >  		struct drm_file *file);
> >  
> >  int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma);
> > -int etnaviv_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf);
> > +int etnaviv_gem_fault(struct vm_fault *vmf);
> >  int etnaviv_gem_mmap_offset(struct drm_gem_object *obj, u64 *offset);
> >  struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj);
> >  void *etnaviv_gem_prime_vmap(struct drm_gem_object *obj);
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives