linux-kernel - Re: [PATCH 1/9] virtio_pci: remove struct virtio_pci_vq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170203082250.GA26800@lst.de>
Date:   Fri, 3 Feb 2017 09:22:50 +0100
From:   Christoph Hellwig <hch@....de>
To:     Jason Wang <jasowang@...hat.com>
Cc:     Christoph Hellwig <hch@....de>, mst@...hat.com, axboe@...nel.dk,
        pbonzini@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] virtio_pci: remove struct virtio_pci_vq_info

On Fri, Feb 03, 2017 at 03:54:36PM +0800, Jason Wang wrote:
>> +	list_for_each_entry(vq, &vp_dev->vdev.vqs, list) {
>> +		if (vq->callback && vring_interrupt(irq, vq) == IRQ_HANDLED)
>
> The check of vq->callback seems redundant, we will check it soon in 
> vring_interrupt().

Good point - I wanted to keep things exactly as-is and dіdn't notice
we were already protected.